Re: Re: [PATCH] zcache: fix "zcache=" kernel parameter

From: Michal Hocko
Date: Wed Jul 24 2013 - 07:42:16 EST

On Wed 24-07-13 12:32:32, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> On Wednesday, July 24, 2013 12:04:41 PM Michal Hocko wrote:
> > On Wed 24-07-13 12:02:35, Michal Hocko wrote:
> > > I have posted a similar fix quite some time ago and I guess Greg should
> > > already have it.
> >
> > For reference
> There was a reply from Greg:

I guess you meant

> and it seems that Greg's request has not been fullfilled.

Bob Liu has resent the patch (I cannot find the email in the archive).

> Anyway Piotr's patch seems to be more complete:
> - it also fixes case in which invalid "zcache=" option is given (returns
> an error value 1 while with your patch the code still erronously retuns 0)
> - it prints information about compressor type being used when "zcache="
> option is used (your patch skips it due to addition of "goto out_alloc")

I do not care which one will make it I just pointed out that there is
another patch dealing with the same and it is a question how far that
one went.
Michal Hocko
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at