Re: [REVIEW][PATCH] vfs: Lock in place mounts from more privilegedusers

From: Serge E. Hallyn
Date: Wed Jul 24 2013 - 11:30:31 EST


Quoting Serge E. Hallyn (serge@xxxxxxxxxx):
> Quoting Eric W. Biederman (ebiederm@xxxxxxxxxxxx):
> >
> > Serge does this patch break lxc? I think all should be well but I want
> > to make certain there is not some hidden case where this fundamentaly
> > breaks some functionality.
>
> I haven't yet tried. I'll build and test a kernel today. I'm pretty
> sure all the child's mounts are done after clone, so I *think* the worst
> case will be that the unmounting of put_old after pivot_root() will
> be noisy. Will let you know.
>
> -serge

Just tested it - works fine. Warns about all of the failed umounts.

Acked-by: Serge Hallyn <serge.hallyn@xxxxxxxxxxxxx>

( Mind you I'm not approving of the idea of hiding mounts as a security
mechanisms, but I know that neither are you :)

thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/