Re: [PATCH 2/2] Drivers: hv: balloon: Online the hot-added memory"in context"

From: Dave Hansen
Date: Wed Jul 24 2013 - 17:04:33 EST

On 07/24/2013 02:29 PM, K. Y. Srinivasan wrote:
> /*
> - * Wait for the memory block to be onlined.
> - * Since the hot add has succeeded, it is ok to
> - * proceed even if the pages in the hot added region
> - * have not been "onlined" within the allowed time.
> + * Before proceeding to hot add the next segment,
> + * online the segment that has been hot added.
> */
> - wait_for_completion_timeout(&dm_device.ol_waitevent, 5*HZ);
> + online_memory_block(start_pfn);

Ahhhhh.... You've got a timeout in the code in order to tell the
hypervisor that you were successfully able to add the memory? The
userspace addition code probably wasn't running within this timeout
period. right?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at