Re: [PATCH v2 1/2] staging: gdm7240: adding LTE USB driver

[Dan Carpenter]

> +static int gdm_lte_ioctl_get_data(struct wm_req_t *req, struct net_device *dev)
> +{
> +	u16 id = req->data_id;
> +
> +	switch (id) {
> +	case GET_ENDIAN_INFO:
> +		/* required for the user space application to find out device endian */
> +		get_dev_endian(&req->data, dev);
> +		break;
> +	default:
> +		printk(KERN_ERR "glte: ioctl - unknown type %d\n", id);
> +		break;
> +	}
> +	return 0;
> +}

This should be a sysfs file not an ioctl.  What would break if we
fixed this right now (as opposed to waiting until we can't change
the API?).

Otherwise if we can't change this, then it should return an error
code instead of printing a message.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/