Re: [PATCH 6/8] staging/lustre: fix Kconfig bool defaults
From: Peng Tao
Date: Wed Jul 24 2013 - 22:37:18 EST
On Thu, Jul 25, 2013 at 3:35 AM, Sam Ravnborg <sam@xxxxxxxxxxxx> wrote:
> On Wed, Jul 24, 2013 at 04:31:30PM +0800, mail-agent-noreply@xxxxxxx wrote:
>> From: Peng Tao <bergwolf@xxxxxxxxx>
>> Should be y instead of true.
>> Reported-by: Paul Bolle <pebolle@xxxxxxxxxx>
>> Cc: Andreas Dilger <andreas.dilger@xxxxxxxxx>
>> Signed-off-by: Peng Tao <tao.peng@xxxxxxx>
>> drivers/staging/lustre/lustre/Kconfig | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>> diff --git a/drivers/staging/lustre/lustre/Kconfig b/drivers/staging/lustre/lustre/Kconfig
>> index 9ae7fa8..e3b3c74 100644
>> --- a/drivers/staging/lustre/lustre/Kconfig
>> +++ b/drivers/staging/lustre/lustre/Kconfig
>> @@ -52,4 +52,4 @@ config LUSTRE_DEBUG_EXPENSIVE_CHECK
>> config LUSTRE_TRANSLATE_ERRNOS
>> depends on LUSTRE_FS && !X86
>> - default true
>> + default y
> This was the file that contained some buggy "default false" IIRC.
> Please delete these.
The default false lines were already deleted by Paul Bolle.
Please see commit 68a8029799ad368ee82a5cf509a2b5b802837ce9 in Greg's
Author: Paul Bolle <pebolle@xxxxxxxxxx>
Date: Sat Jul 13 20:46:39 2013 +0200
staging/lustre/libcfs: drop bogus Kconfig default
Commit 4b5b4c7222 ("staging/lustre/libcfs: restore LINVRNT") added
"default false" to this Kconfig file. It was obviously meant to use
"default n" here. But we might as well drop this line, as a Kconfig bool
defaults to 'n' anyway.
Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/