Re: [40/85] net/tg3: Avoid delay during MMIO access
From: Ben Hutchings
Date: Thu Jul 25 2013 - 00:16:25 EST
On Wed, 2013-07-24 at 14:09 -0700, David Miller wrote:
> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Wed, 24 Jul 2013 12:45:04 -0700 (PDT)
> > From: Luis Henriques <luis.henriques@xxxxxxxxxxxxx>
> > Date: Wed, 24 Jul 2013 17:42:04 +0100
> >> I believe you didn't want to have these two invocations to the
> >> pci_channel_offline() function. i guess you wanted to have one of
> >> these moved to the other branch of the 'if' statement.
> >> [ btw, I've just replied to an email by David S. Miller about his
> >> backport to 3.4 (and 3.2) of this commit. ]
> > Yes, indeed, both of these backports were done incorrectly.
> Greg/Ben, please drop the tg3 patch of my networking bits from your
> queues, I'll send a fixed up version soon.
It's not in the queue yet, but I'll remember not to add it.
Once a job is fouled up, anything done to improve it makes it worse.
Description: This is a digitally signed message part