Re: [PATCH 1/1] TX throttling bug-fixing patch of AX88179_178A
From: Ming Lei
Date: Thu Jul 25 2013 - 01:25:23 EST
On Thu, Jul 25, 2013 at 1:10 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> On Thu, 2013-07-25 at 10:28 +0800, Ming Lei wrote:
>> It depends if size of sg buffer(except for last one) in the sg list can be
>> divided by usb endpoint's max packet size(512 or 1024), at least there
>> is the constraint:
>> I am wondering if network stack can meet that. If not, it might be a
>> bit difficult
>> because lots of USB host controller don't support that, and driver may have
>> to support SG and non-SG at the same time for working well on all HCs.
> I do not see the problem.
> If one skb has 2 fragments of 32KB, couldn't they be split into 64 1K
> segments by the device driver ?
OK, if length of fragments of all SKBs from network stack can always guarantee
to be divided by 1024, that is fine, seems I worry about too much, :-)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/