Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" offunction vga16fb_destroy()

From: Gu Zheng
Date: Thu Jul 25 2013 - 06:06:16 EST


On 07/25/2013 05:58 PM, Geert Uytterhoeven wrote:

> On Thu, Jul 25, 2013 at 5:37 AM, Gu Zheng <guz.fnst@xxxxxxxxxxxxxx> wrote:
>> Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(),
>> but left the variable "dev" unused, delete it.
>
> When referring to another commit, please also include the oneline summary of
> the commit, to make it easier for people to see what it's about.

Got it, thanks for your reminder.:)

>
> E.g. "Commit e21d2170f36602ae2708 ("video: remove unnecessary
> platform_set_drvdata()") removed the unnecessary platform_set_drvdata(),
> but left the variable "dev" unused, delete it."

This is easier reading. I'll update it.

Regards,
Gu


>
> Thanks!
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/