Re: [PATCH] video: xilinxfb: Fix compilation warning

From: Geert Uytterhoeven
Date: Thu Jul 25 2013 - 06:09:46 EST


On Wed, Jul 24, 2013 at 10:24 AM, Michal Simek <monstr@xxxxxxxxx> wrote:
>> Just now, I tested that the same problem happens on ARM config.
>> Also, I solved it by adding '&' operator.
>>
>> '&' operator is necessary as below:
>>
>> dev_dbg(dev, "regs: phys=%pa, virt=%p\n",
>> &drvdata->regs_phys, drvdata->regs);
>> ^^^
>>
>> dev_dbg(dev, "fb: phys=%pa, virt=%p, size=%x\n",
>> &drvdata->fb_phys, drvdata->fb_virt, fbsize);
>> ^^^
>
> ok.
>
> The truth is as I said there are just 5 files in the whole kernel
> which are using %pa and if %pa is right way to go we should
> probably fix all off them.

"%pa" is a quite recent addition (v3.9).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/