Re: [PATCH] APEI/ERST: Fix error message formatting
From: Naveen N. Rao
Date: Thu Jul 25 2013 - 07:23:54 EST
On 07/24/2013 10:53 PM, Joe Perches wrote:
On Wed, 2013-07-24 at 22:43 +0530, Naveen N. Rao wrote:
On 2013/07/22 11:01PM, Borislav Petkov wrote:
From: Borislav Petkov <bp@xxxxxxx>
[ 5.525861] ERST: Can not request iomem region <0x c7eff000-0x c7f00000> for ERST.
This needs to have leading zeroes. Make it so.
Why does it need leading zeros?
While looking at this, I noticed that we seem to be using varying field
widths in our APEI code:
- einj.c has two instances using %#010llx.
- apei-base.c uses widths of 10 (4 bytes) and 6 (2 bytes).
Not sure if these are intentional and those fields truly aren't 64-bit
(as suggested by the usage of long long int).
I suggest using "0x%llx" everywhere unless there's a
compelling reason like columnar alignment for them.
I think that might be better. I see that these changes were done in
commit 46b91e37. Copying Bjorn Helgaas.
On 07/24/2013 11:40 PM, Borislav Petkov wrote:
> That's an interesting question but I think you're better fitted to
> answer it - I try to avoid the APEI spec as much as possible.
Oh, I've hardly scratched the surface w.r.t APEI. I think I'll let the
experts comment on this :)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/