Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA
From: Bjorn Helgaas
Date: Thu Jul 25 2013 - 13:01:34 EST
On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh
> Sorry for letting this discussion slide, I was busy on other works:-(
> Anyway, the summary of previous discussion is:
> - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on
> boot. This expects PCI enumeration is done before IOMMU
> initialization as follows.
> (1) PCI enumeration
> (2) fs_initcall ---> device reset
> (3) IOMMU initialization
> - This works on x86, but does not work on other architecture because
> IOMMU is initialized before PCI enumeration on some architectures. So,
> device reset should be done where IOMMU is initialized instead of
> - Or, as another idea, we can reset devices in first kernel(panic kernel)
> Resetting devices in panic kernel is against kdump policy and seems not to
> be good idea. So I think adding reset code into iommu initialization is
> better. I'll post patches for that.
Of course nobody *wants* to do anything in the panic kernel. But
simply saying "it's against kdump policy and seems not to be a good
idea" is not a technical argument. There are things that are
impractical to do in the kdump kernel, so they have to be done in the
panic kernel even though we know the kernel is unreliable and the
attempt may fail.
My point about IOMMU and PCI initialization order doesn't go away just
because it doesn't fit "kdump policy." Having system initialization
occur in a logical order is far more important than making kdump work.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/