Re: [PATCH v2] tile: support PTP using the tilegx mPIPE (IEEE 1588)
From: Richard Cochran
Date: Thu Jul 25 2013 - 13:56:10 EST
On Thu, Jul 25, 2013 at 11:19:38AM -0400, Chris Metcalf wrote:
> Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx>
> - Moved Kconfig stanza to drivers/ethernet/tile/Kconfig
> - Clarify minimum and maximum frequency adjustments
So if the requested frequency adjustment lies within the +/-30 ppm
interval, then you return EINVAL? Maybe ERANGE would be better.
Perhaps the driver should just round to the closest value it can
support? Unfortunately, we don't have a way to communicate this kind
of limitation to user space.
> - Merge PTP support into tilegx.c driver source code directly
> - Support SIOCSHWTSTAMP ioctl appopriately
> - Rebased to be the last patch in the series to simplify development
Anyhow, this looks much better to me now.
Acked-by: Richard Cochran <richardcochran@xxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/