Re: [PATCH 4/5] Intel MIC Card Driver Changes for Virtio Devices.

[Sudeep Dutt]

On Wed, 2013-07-24 at 21:41 -0700, Greg Kroah-Hartman wrote:
> On Wed, Jul 24, 2013 at 08:31:35PM -0700, Sudeep Dutt wrote:
> > +/*
> > + * Intel MIC Platform Software Stack (MPSS)
> > + *
> > + * Copyright(c) 2013 Intel Corporation.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License, version 2, as
> > + * published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful, but
> > + * WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > + * General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program; if not, write to the Free Software
> > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301
> > + * USA.
> > + *
> > + * The full GNU General Public License is included in this distribution in
> > + * the file called "COPYING".
> 
> Someone needs to tell Intel to take out the address paragraph of thier
> "standard template" as it's annoying.  Please remove it, unless you
> personally want to keep the file up to date with the address movements
> of the FSF for the next 40+ years.
> 
Sure, will delete the paragraph with the FSF address across all the
files in the next revision.

> > + * Disclaimer: The codes contained in these modules may be specific to
> > + * the Intel Software Development Platform codenamed: Knights Ferry, and
> > + * the Intel product codenamed: Knights Corner, and are not backward
> > + * compatible with other Intel products. Additionally, Intel will NOT
> > + * support the codes or instruction set in future products.
> 
> What does this mean?  That's a new one to me...
> 
Although the card driver does not contain any Knights Corner (x100)
specific instructions in the source code, we have been asked to include
this disclaimer only in the card driver patches 2 and 4; because the
x100 device has a slightly unique instruction set documented @
http://software.intel.com/en-us/mic-developer. The next generation of
MIC devices should not require this disclaimer in the card driver as
they will use standard x86_64 ISA.  The disclaimer is not present in the
host driver patches 1, 3 and 5 since it is not applicable.

> > +static inline struct device *dev(struct mic_vdev *mvdev)
> > +{
> > +	return mvdev->vdev.dev.parent;
> > +}
> 
> Can you pick a worse name?  And you aren't returning the "device", you
> are returning the parent, so the name (as short as it is), is wrong.
> 
Agreed, will rename in the next revision. We will also review the driver
to ensure that we do not have a similar problem in other files before
posting again.

Thanks,
Sudeep Dutt

> 
> ick.
> 
> greg k-h
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/