Re: [v2 PATCH] regulator: palmas: Store pdata pointer in palmas struct

From: Rhyland Klein
Date: Thu Jul 25 2013 - 14:06:54 EST

On 7/25/2013 2:02 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
> On Thu, Jul 25, 2013 at 01:04:59PM -0400, Rhyland Klein wrote:
>> Store a pointer to the pdata so that if it needs to be used after
>> probe it can be. In the case of booting from DeviceTree, the
>> dev.platform_data may be null, so we need to store this pointer
>> explicitly.
> This doesn't seem to adjust any places where pdata is used to refer to
> the new pointer so does it actually have any effect?

I was thinking the same thing after I sent this. Right now, no this has
no effect. The expectation is that when ldo8-tracking support is posted,
it needs to have access to the pdata. I suppose it could make sense then
to either make this part of that series, or to flatten this directly
into it.

I think it can be fine to merge on its own, but it might make sense then
to include the ldo8 tracking support. Let me see how ready that is to be
posted, and if it is close, this can join it in a patchset.


> * Unknown Key
> * 0x7EA229BD

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at