Re: [PATCH 3/4] ASoc: kirkwood: merge kirkwood-i2c and kirkwood-dma

From: Mark Brown
Date: Thu Jul 25 2013 - 15:16:37 EST

On Thu, Jul 25, 2013 at 11:14:28AM +0200, Jean-Francois Moine wrote:
> To avoid the declaration of a 'kirkwood-pcm-audio' device in the DT,
> this patch merges the kirkwood-i2c and kirkwood-dma drivers into one
> module.

This seems mostly fine, though it may be best to keep kirkwood-dma as a
separate module for the benefit of the S/PDIF support when it gets added
- I had a look at the implementation Russell has and it looks like it
can be added as a separate interface.

> - .platform_name = "kirkwood-pcm-audio",
> + .platform_name = "kirkwood-i2s",

Should the name be done as dev_name() for the interface (I don't know if
there is ever more than one)?

Attachment: signature.asc
Description: Digital signature