Re: [PATCH] mfd: max8925: fix dt code for backlight
From: Olof Johansson
Date: Thu Jul 25 2013 - 17:00:55 EST
On Wed, Jul 24, 2013 at 6:13 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> On Thursday, July 25, 2013 12:42 AM, Olof Johansson wrote:
>> The device-tree enablement for max8925 has several problems, but besides
>> the bindings being wrong (and not having seen review) there's also some
>> bad coding practices on how to fill in the platform_data from device tree.
>> I came across this since it causes a warning when compiling
>> mmp2_defconfig, and instead of doing the minimal fix to silence the
>> warning, I restructured the code a bit.
>> This silences the warning:
>> drivers/video/backlight/max8925_bl.c: In function 'max8925_backlight_probe':
>> drivers/video/backlight/max8925_bl.c:177:3: warning: statement with no effect [-Wunused-value]
>> Note that the bindings themselves need to be revisited too, but that will
>> affect more than just the backlight driver and is best done separately;
>> this just fixes the bad code for the backlight driver.
>> Signed-off-by: Olof Johansson <olof@xxxxxxxxx>
>> Richard, Jingoo, this would be good to see go into 3.11 if you're
>> comfortable with it.
> CC'ed Andrew Morton
> Hi Olof Johansson,
> Currently, there is not git tree for Backlight subsystem.
> I hope that this would go into 3.11 through one of other trees
> with my Ack.
> If not, it will go into 3.12-rc1 through mm-tree.
> Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
Ok, if you don't mind I can take it through arm-soc for 3.11 with your ack then.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/