Re: [PATCHv2 3/3] fb: backlight: HX8357: Add HX8369 support

From: Jingoo Han
Date: Thu Jul 25 2013 - 19:52:18 EST


On Thursday, July 25, 2013 10:05 PM, Maxime Ripard wrote:
>
> From: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
>
> Add support for the Himax HX8369 controller as it is quite similar to the
> hx8357.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx>
> Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> drivers/video/backlight/hx8357.c | 221 ++++++++++++++++++++++++++++++++++++---
> 1 file changed, 206 insertions(+), 15 deletions(-)
>

[....]

> + ret = hx8357_spi_write_byte(lcdev, HX8357_SET_DISPLAY_ON);
> + if (ret < 0)
> + return ret;
> +
> + msleep(100);

Hi Maxime Ripard,

Could you add comment on this huge delay, too?

Best regards,
Jingoo Han


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/