Re: [PATCH -next] staging: gdm724x: use GFP_ATOMIC under spin lock

From: Dan Carpenter
Date: Fri Jul 26 2013 - 03:33:15 EST

On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> A spin lock is taken here so we should use GFP_ATOMIC.

Acked-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

But the locking here is really odd and pointless. usb_submit_urb()
returns asynchronously before the data has been sent, so there is
almost no point in locking around it.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at