Re: [tip:perf/core] perf: Update perf_event_type documentation

[Peter Zijlstra]

On Thu, Jul 25, 2013 at 11:24:05PM -0400, Vince Weaver wrote:
> On Thu, 25 Jul 2013, Peter Zijlstra wrote:
> 
> > On Thu, Jul 25, 2013 at 08:34:51AM -0400, Vince Weaver wrote:
> > > Yes, I meant the addition of the sample_id fields to the existing sample 
> > > values.  Though if Peter is right and those have always been there since 
> > > the beginning and just not documented then that won't break anything.  
> > > The commit message wasn't really as clear as it could be.
> > 
> > /me writes "I shall write better Changelogs." a hundred times.
> 
> yes, sorry, I shouldn't have been so grumpy about it.

I don't mind; I wish people would tell me my changelogs suck before they
get committed though; I can still fix them at that point.

It not only helps others, but also myself. I've on many occasion kicked
myself for not writing clearer changelogs when investigating something
months (or years) after I wrote the initial code.

The problem is that I mostly know what I mean when I write it and I'm
not very good at writing in the first place -- real changelogs often
take longer to write than the actual code. But I guess that's true for
many people.

Anyway.. I'm ever trying to write better changelogs, but alas there's
also always far more room for improvement :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/