Re: [Ksummit-2013-discuss] DT bindings as ABI [was: Do we havepeople interested in device tree janitoring / cleanup?]
From: Jason Cooper
Date: Fri Jul 26 2013 - 09:27:51 EST
On Fri, Jul 26, 2013 at 03:09:29PM +0200, Richard Cochran wrote:
> On Fri, Jul 26, 2013 at 10:42:24AM +0100, David Woodhouse wrote:
> > On Fri, 2013-07-26 at 10:01 +0200, Richard Cochran wrote:
> > > On Thu, Jul 25, 2013 at 03:37:53PM -0600, Jason Gunthorpe wrote:
> > > >
> > > > We use DT has a kernel configuration input. Our environment is
> > > > designed to guarantee 100% that the kernel and DT match exactly. DT
> > > > very deliberately isn't an ABI boundary in our systems.
> > >
> > > Think about what you just said.
> > >
> > > The DT describes the *hardware* not the kernel. Why should you ever
> > > need to update your DT at all?
> > Well, the nodes which describe hardware devices, according to the
> > bindings which form an ABI contract between DT and drivers, should not
> > normally change. Although they *can* change, if for example you change
> > the MAC address and that's stored there. Or you change the PHY you want
> > it to use. Or something like that. The *ABI* doesn't change, but the
> > data you express *using* that ABI can change. That's kind of the point.
> Unless I totally misunderstood, the thread is talking about letting
> established bindings change with each new kernel version. I am
> opposed to that.
> Of course, a user may want to change the values of his MAC addresses,
> if he needs to. But he should never have to change *how* he specifies
> those addresses.
The other dynamic change that bears mentioning here is attributes which
have been configured by the bootloader. For example, in mvebu, we have
the Schrodinger's Cat register. It allows you to reconfigure the base
address of the registers from *within* that register range. If the
bootloader does this, the DT needs to be updated to reflect the current
hardware configuration. Otherwise, the kernel is stuck poking around at
memory addresses hoping to find something sane.
But this falls into the same category as you mentioned, but outside of
> So, as long as everyone can agree to the principle that a working DT
> should remain working after a kernel upgrade, then I'll shut up. In
> actual fact, this is not the case today, nor was it ever so in the
> past, AFAICT, but it never hurts to set goals.
Some instability is necessary as we figure out what 'stable' is.
Otherwise, things would've been so rigid, we'd've never made any
progress. I'd say we now a sufficient body of code and experience to
start enforcing the goal.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/