[PATCH v5.1 6/8] memcg, vmscan: Do not attempt soft limit reclaim if it would not scan anything

From: Michal Hocko
Date: Fri Jul 26 2013 - 12:06:50 EST

mem_cgroup_should_soft_reclaim controls whether soft reclaim pass is
done and it always says yes currently. Memcg iterators are clever to
skip nodes that are not soft reclaimable quite efficiently but
mem_cgroup_should_soft_reclaim can be more clever and do not start the
soft reclaim pass at all if it knows that nothing would be scanned

In order to do that, simply reuse mem_cgroup_soft_reclaim_eligible for
the target group of the reclaim and allow the pass only if the whole
subtree wouldn't be skipped.

Changes since v1
- do not export mem_cgroup_root and teach mem_cgroup_soft_reclaim_eligible
to handle NULL memcg as mem_cgroup_root

Signed-off-by: Michal Hocko <mhocko@xxxxxxx>
mm/memcontrol.c | 6 +++++-
mm/vmscan.c | 4 +++-
2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index c1be265..8629ca6 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -1909,7 +1909,11 @@ enum mem_cgroup_filter_t
mem_cgroup_soft_reclaim_eligible(struct mem_cgroup *memcg,
struct mem_cgroup *root)
- struct mem_cgroup *parent = memcg;
+ struct mem_cgroup *parent;
+ if (!memcg)
+ memcg = root_mem_cgroup;
+ parent = memcg;

if (res_counter_soft_limit_excess(&memcg->res))
return VISIT;
diff --git a/mm/vmscan.c b/mm/vmscan.c
index e03494a..b45ff5b 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -142,7 +142,9 @@ static bool global_reclaim(struct scan_control *sc)

static bool mem_cgroup_should_soft_reclaim(struct scan_control *sc)
- return !mem_cgroup_disabled();
+ struct mem_cgroup *root = sc->target_mem_cgroup;
+ return !mem_cgroup_disabled() &&
+ mem_cgroup_soft_reclaim_eligible(root, root) != SKIP_TREE;
static bool global_reclaim(struct scan_control *sc)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/