Re: [PATCH] drivers/rtc/rtc-palmas.c: support for backup batterycharging

From: Laxman Dewangan
Date: Sat Jul 27 2013 - 03:21:14 EST

On Friday 26 July 2013 10:12 PM, Stephen Warren wrote:
On 07/26/2013 10:35 AM, Mark Brown wrote:
On Fri, Jul 26, 2013 at 09:40:15AM -0600, Stephen Warren wrote:

Given there's only 1 battery, I think "back-" is redundant in
the property names. Since that shortens the names a bit, I'd
suggest spelling everything out in full, perhaps:
Isn't there an integrated charger on the PMIC? If there is then
it's useful to identify which is being talked about (even if it
should be relatively obvious).
Oh yes, that's probably true. This is of course the binding for the
RTC sub-module in the PMIC though.

I have currently Palma series 2 devices tps65913 and tps80036. TPS80036 supports the charging of main battery. Both chip support the backup battery charging. Hence it is good to name the back-* here.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at