Re: [PATCH 1/2] pinctrl: pinconf_generic: add utility functions foradd map/configs

From: Laxman Dewangan
Date: Sat Jul 27 2013 - 06:03:17 EST

On Friday 26 July 2013 11:06 PM, Stephen Warren wrote:
On 07/26/2013 04:15 AM, Laxman Dewangan wrote:
Some of pincontrol driver needs the utility function to create map
list. The utility function needed for adding mux, configs etc.
Which other drivers already contain this code? Are you planning on
converting them over to use these new functions? The code looks
familiar, so I assume it's just cut/paste from Tegra with some renames,
so I didn't read it through in detail.

Yes, these functions are taken from the pinctrl-tegra driver. Other drivers which have similar implementation are nomadik, tegra, abx500, tz1090, tz1090-pdc.
So All can use these utility function to avoid duplication and reduce code size.
Yes, I have plan to use this in Tegra atleast but once this patch get accepted.

drivers/pinctrl/pinconf-generic.c | 105 +++++++++++++++++++++++++++++++
include/linux/pinctrl/pinconf-generic.h | 52 +++++++++++++++
I don't think those are the correct files for this code. Presumably
there's no reason at all why a pinctrl driver that doesn't require
CONFIG_GENERIC_PINCONF can't use these basic utility functions. Perhaps
add a new pinctrl-utils file?

I thought generic implementation of parsing of dt is pinctrl-generic file and as these newly added APIs are require for the parsing the DT node, I added here.
I can move this to pinctrl-util.c/h also.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at