Re: [ 06/79] net: Swap ver and type in pppoe_hdr
From: Ben Hutchings
Date: Sat Jul 27 2013 - 23:14:58 EST
On Sat, 2013-07-27 at 17:55 -0700, David Miller wrote:
> From: Ben Hutchings <ben@xxxxxxxxxxxxxxx>
> Date: Sat, 27 Jul 2013 16:58:28 +0100
> > I'm not so sure this is suitable for stable. It doesn't seem to be
> > helpful to either userland or kernel code.
> > In the kernel, we were checking that ver == 1 and type == 1 thus this
> > wasn't hurting us.
> > If userland does anything more with these fields then it's probably
> > already working around the swapped fields. It can work with both old
> > and new headers by doing:
> It's up to you, I would rather have the corrected version propagated
> as soon as possible. But that's just me.
Let's see what Greg thinks.
All extremists should be taken out and shot.
Description: This is a digitally signed message part