Re: [PATCH v2 2/2] regulator: Add Dialog DA9063 voltage regulatorssupport.

From: Mark Brown
Date: Sun Jul 28 2013 - 08:52:03 EST

On Thu, Jul 25, 2013 at 07:39:03PM +0200, Philipp Zabel wrote:

> - 1x power switch to switch on/off 32 KHz oscilator output (32K_OUT).

The driver looks good except this should be implemented using the clock
API not the regulator API - some drivers did this while we didn't have a
clock API but we do now and in any case the clock shouldn't appear as a
regulator in the DT bindings.

Attachment: signature.asc
Description: Digital signature