Re: [PATCH v1] backlight-lm3630-apply chip revision

From: Jingoo Han
Date: Sun Jul 28 2013 - 21:58:43 EST

On Friday, July 26, 2013 6:02 PM, Daniel Jeong wrote:
> Subject: [PATCH v1] backlight-lm3630-apply chip revision

Please don't use this subject, as I mentioned.
Also, this patch version is v2.

Thus, when you send the next version of this patch,
you should use the subject as below:

[PATCH v3] backlight: lm3630: apply chip revision

According to 'Documentation/SubmittingPatches',
15) The canonical patch format
The canonical patch subject line is:
Subject: [PATCH 001/123] subsystem: summary phrase

> The LM3630 chip was revised by TI and chip name was also changed to LM3630A.
> And register map, default values and intiial sequences are changed.

Looks good.

> lm3630_bl.c and .h files are deleted
> lm3630_bla.c and .h files are added

Fix the typo: lm3630_bla.c -> lm3630a_bl.c

The following is simpler.
lm3630_bl.{c,h} files are changed to lm3630a_bl.{c,h}.


Please, don't add meaningless commit message.
If you want to mention web address of your company,
please mention what it means as below:

The full datasheets are available from TI website:

> Signed-off-by: daniel jeong <daniel.jeong@xxxxxx>

Please use upper case as below:
Signed-off-by: Daniel Jeong <daniel.jeong@xxxxxx>
^^^ ^^^

In my opinion, you have to fix your .gitconfig file as below:

email = daniel.jeong@xxxxxx
name = Daniel Jeong

Daniel Jeong,
Please, read the './Documentation/SubmittingPatches', before you send
your patch.

Best regards,
Jingoo Han

> ---
> drivers/video/backlight/Kconfig | 6 +-
> drivers/video/backlight/Makefile | 2 +-
> drivers/video/backlight/lm3630_bl.c | 475 -----------------------------
> drivers/video/backlight/lm3630a_bl.c | 482 ++++++++++++++++++++++++++++++
> include/linux/platform_data/lm3630_bl.h | 57 ----
> include/linux/platform_data/lm3630a_bl.h | 65 ++++
> 6 files changed, 551 insertions(+), 536 deletions(-)
> delete mode 100644 drivers/video/backlight/lm3630_bl.c
> create mode 100644 drivers/video/backlight/lm3630a_bl.c
> delete mode 100644 include/linux/platform_data/lm3630_bl.h
> create mode 100644 include/linux/platform_data/lm3630a_bl.h

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at