Re: regulator: pfuze100: A few small questions

[Axel Lin]

2013/7/29 Axel Lin <axel.lin@xxxxxxxxxx>:
> Hi Robin,
> 2 questions about the code in pfuze100 driver:
>
> 1)
> Both PFUZE100_REVID and PFUZE100_FABID are defined as 0x3.
> So I'm wondering if it's a typo in one of the register address?
> If they are actually the same register, we don't need to read the same
> register twice in pfuze_identify().
>
> 2)
> What is the the purpose of stby_reg and stby_mask?
> Seems current code does not use it?


One more question:

Current code adjust min_uV and uV_step when SW2~SW4 high bit is set.
I'm wondering if n_voltages is correct or not in this case because
the n_voltages is calculated by original equation (max-min/step + 1).
What is the max_uV when SW2~SW4 high bit is set?

Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/