Re: [PATCH v2 00/42] ARM: at91: move to common clk framework

From: boris brezillon
Date: Mon Jul 29 2013 - 05:35:31 EST

On 29/07/2013 10:00, Richard Genoud wrote:
2013/7/26 boris brezillon <b.brezillon@xxxxxxxxxxx>:
On 26/07/2013 17:44, boris brezillon wrote:
I found 2 bugs:
1) the main frequency ready test in recalc_rate function is wrong
2) the common clk framework uses the first match for dt clk registration
and main clk has this compatible property:
compatible = "atmel,at91rm9200-clk-main", "fixed-clock";
As a result the main clk is always bound to the fixed-clock driver
which set the clock frequency to 0 if 'clock-frequency' property is

These bugs will be fixed in next version.
Tell me if you want need thesse patches for testing purpose.
Hi Boris,

I tested your patch, the clock is not at 0 anymore:
AT91: PIT: mck rate = 8333333

And it's booting correctly.
There's a small bug I found in the at91sam9x5 dtsi file (ssc id is 28,
not 27). (patch attached)

And yes, I could use your patches for some more tests !


Hi Richard,

Thanks for the bug report.

You'll find in attachements the pre-v3 series fixing the detected bugs (including the ssc clock id bug).

If you need anything else please let me know.

Best Regards,


Attachment: at91-clk-v3.tgz
Description: application/compressed-tar