[PATCH 7/9] ARM: edma: Don't clear EMR of channel in edma_stop
From: Joel Fernandes
Date: Mon Jul 29 2013 - 09:33:15 EST
We certainly don't want error conditions to be cleared anywhere
as this will make us 'forget' about missed events. We depend on
knowing which events were missed in order to be able to reissue them.
This fixes a race condition where the EMR was being cleared
by the transfer completion interrupt handler.
Basically, what was happening was:
\__TC Interrupt (Almost same time as ARM is executing
TC interrupt handler, an event got missed and also forgotten
by clearing the EMR).
The EMR is ultimately being cleared by the Error interrupt
handler once it is handled so we don't have to do it in edma_stop.
Signed-off-by: Joel Fernandes <joelf@xxxxxx>
arch/arm/common/edma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/common/edma.c b/arch/arm/common/edma.c
index 10995b2..dec772e 100644
@@ -1328,7 +1328,6 @@ void edma_stop(unsigned channel)
edma_shadow0_write_array(ctlr, SH_EECR, j, mask);
edma_shadow0_write_array(ctlr, SH_ECR, j, mask);
edma_shadow0_write_array(ctlr, SH_SECR, j, mask);
- edma_write_array(ctlr, EDMA_EMCR, j, mask);
pr_debug("EDMA: EER%d %08x\n", j,
edma_shadow0_read_array(ctlr, SH_EER, j));
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/