2013/7/29 boris brezillon <b.brezillon@xxxxxxxxxxx>:This was requested by Jean-Christophe too.On 29/07/2013 10:00, Richard Genoud wrote:Working on sam9g35ek !2013/7/26 boris brezillon <b.brezillon@xxxxxxxxxxx>:Hi Richard,On 26/07/2013 17:44, boris brezillon wrote:Hi Boris,
I found 2 bugs:
1) the main frequency ready test in recalc_rate function is wrong
2) the common clk framework uses the first match for dt clk registration
and main clk has this compatible property:
compatible = "atmel,at91rm9200-clk-main", "fixed-clock";
As a result the main clk is always bound to the fixed-clock driver
which set the clock frequency to 0 if 'clock-frequency' property is
These bugs will be fixed in next version.
Tell me if you want need thesse patches for testing purpose.
I tested your patch, the clock is not at 0 anymore:
AT91: PIT: mck rate = 8333333
And it's booting correctly.
There's a small bug I found in the at91sam9x5 dtsi file (ssc id is 28,
not 27). (patch attached)
And yes, I could use your patches for some more tests !
Thanks for the bug report.
You'll find in attachements the pre-v3 series fixing the detected bugs
(including the ssc clock id bug).
If you need anything else please let me know.
you can add my:
Tested-by: Richard Genoud <richard.genoud@xxxxxxxxx>
One remark though:
Maybe it would be interesting to keep using the defines in the device
tree for peripheral IDs.
For instance, in arch/arm/boot/dts/at91sam9x5.dtsi : (patch 33)
id = <28>;
May be more readable with the SSC id AT91SAM9X5_ID_SSC, as it was
defined in arch/arm/mach-at91/at91sam9x5.c (removed with patch 20)
IMHO, all AT91SAM9X5_ID_xxx in
arch/arm/mach-at91/include/mach/at91sam9x5.h can me moved in
include/dt-bindings/ and used in at91sam9x5.dtsi