Re: [PATCH 1/2] mfd: Add Dialog DA9063 core driver.
From: Philipp Zabel
Date: Mon Jul 29 2013 - 11:58:26 EST
Am Montag, den 29.07.2013, 16:46 +0100 schrieb Lee Jones:
> > > > > Signed-off-by: Krystian Garbaciak <krystian.garbaciak@xxxxxxxxxxx>
> > > > > Signed-off-by: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>
> > > > > ---
> > > > > drivers/mfd/Kconfig | 12 +
> > > > > drivers/mfd/Makefile | 3 +
> > > > > drivers/mfd/da9063-core.c | 177 ++++++
> > > > > drivers/mfd/da9063-i2c.c | 197 ++++++
> > > > > drivers/mfd/da9063-irq.c | 193 ++++++
> > > > > include/linux/mfd/da9063/core.h | 110 ++++
> > > > > include/linux/mfd/da9063/pdata.h | 114 ++++
> > > > > include/linux/mfd/da9063/registers.h | 1090 ++++++++++++++++++++++++++++++++++
> > > > > 8 files changed, 1896 insertions(+)
> > > >
> > > > Whoah!! Who's going to want to review a 2k line patch?
> > Well, most of those lines consist of the register and bit(field)
> > definitions and the assignment of those to regmap and regmap-irq.
> > I could split this into (core+i2c) and (irq) parts if you insist.
> I won't insist on it, but bear in mind it might take me longer to set
> aside enough time to review the patch than if it were broken up. In
> the latter case I could pick at it throughout the working day.
Alright. I'll split it up a bit, then.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/