Re: [PATCH 2/4] usb: phy: add am335x pieces to generic phy

[Sebastian Andrzej Siewior]

* Felipe Balbi | 2013-07-29 15:22:18 [+0300]:

>On Fri, Jul 26, 2013 at 10:15:55PM +0200, Sebastian Andrzej Siewior wrote:
>> This patch copies the phy support bits from dsps into the generic phy
>> driver. Most code can be re-used except for the on/off.
>> The additional am335x can be removed once we have a phy driver that does
>> more than this.
>> 
>> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
>
>this is good too, but looking at the amount of am335x-specific code in
>the driver now it makes me wonder if we want to convert phy-generic.c
>into a library...

So I just looked over George Cherian phy driver. I think the simplest
thing would be to add the usb wakeup path to the driver here. Earlier I
hoped that we could just remove the am335x bits and avoid the library
thingy :)
Since the library probably makes sense:
- before or after this patch
- where do I get the memory for this wakeup register? It is somewhere in
  the "reset module" of the am335x

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/