Re: [PATCH] bluetooth: remove wrong dependency for BT_ATH3K
From: Hector Palacios
Date: Tue Jul 30 2013 - 04:00:02 EST
On 07/29/2013 06:43 PM, Marcel Holtmann wrote:
The Atheros firmware download driver is not dependent on HCI
USB driver. This driver is needed to complement any Atheros
driver like BT_HCIUART_ATH3K.
Signed-off-by: Hector Palacios <hector.palacios@xxxxxxxx>
CC: Suraj Sumangala <suraj@xxxxxxxxxxx>
CC: Vikram Kandukuri <vikram.kandukuri@xxxxxxxxxxx>
drivers/bluetooth/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 11a6104..a1d482b 100644
@@ -222,7 +222,6 @@ config BT_MRVL_SDIO
tristate "Atheros firmware download driver"
- depends on BT_HCIBTUSB
Bluetooth firmware download driver.
I am confused now. How can an USB driver work with an UART driver? If you do not want to depend on BT_HCIBTUSB then that is fine, but at least you need to depend on USB.
The thing is I have an Atheros AR6233 chipset which has wireless and Bluetooth.
Bluetooth part in this chip operates as a UART. The driver for this is hci_ath.c but I
also need to download the firmware to the chip, and for this I need to compile
ath3k.c. However I don't need BT_HCIBTUSB.
But you are right, looking at the source code of ath3k.c it is calling usb commands,
so it needs to depend on USB at least.
This brings an interesting question: shouldn't the firmware download part be isolated
from the USB driver? After all, I want to communicate with a UART bluetooth chip.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/