Re: [linux-sunxi] Re: [PATCH 1/2] Initial support for Allwinner'sSecurity ID fuses

From: Oliver Schinagl
Date: Tue Jul 30 2013 - 13:42:41 EST

On 30-07-13 16:20, Greg KH wrote:
On Tue, Jul 30, 2013 at 03:22:55PM +0200, Oliver Schinagl wrote:
Let me go look at how I can make this work "easier", give me a few days.
Not wanting to be rude, but it has been a little more then a few
days, any progress? Just want to know what I have to modify my
driver to so it can go into the next merge window :)

What? Oh crap.

I saw this old email in my todo box last week and for some stupid reason
I thought I had already taken care of this, otherwise why would I have
left it around for so long?...

Ugh, very sorry about that...

Hm, this is a mess. I hate platform devices...

Anyway, as you want to get this into 3.12, and I'm not going to be able
to get the core infrastructure into the platform device by then, just go
ahead and do a sysfs_create_group() call in your device probe callback
for now. That will register the needed files for the device (not the
driver, DOH that was stupid of me...) and all should be ok.

Yes, you will still race with userspace, but as right now, there's no
way that _any_ platform driver can do this "correctly", you will be in
good company. I'll clean up all platform drivers in a sweep of the tree
after 3.12 or so when I get the needed infrastructure in place for the
platform_driver code.

Again, very sorry for all of this, you have helped me out a lot in
figuring out that this is a mess, and should be fixed up better, but in
the end, you are pretty much back at the beginning of what you
originally wanted to do, right?
Alright, I'll modify it to use sysfs_create_group() and try to leave it as much as it is no to ease the transition.

I owe you a beer, at the least, my apologies...
Pff, free booze is far better ;) I kid I kid, though Maxime helped a lot there.

Ok expect a v6 I think for review and hopefully merge tomorrow.


greg k-h

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at