Re: [PATCH 25/36] SCSI: sd: convert class code to use dev_groups
From: James Bottomley
Date: Tue Jul 30 2013 - 15:22:22 EST
On Tue, 2013-07-30 at 12:01 -0700, Greg Kroah-Hartman wrote:
> On Tue, Jul 30, 2013 at 04:11:52PM +0000, James Bottomley wrote:
> > On Wed, 2013-07-24 at 15:05 -0700, Greg Kroah-Hartman wrote:
> > > The dev_attrs field of struct class is going away soon, dev_groups
> > > should be used instead. This converts the scsi disk class code to use
> > > the correct field.
> > >
> > > It required some functions to be moved around to place the show and
> > > store functions next to each other, the old order seemed to make no
> > > sense at all.
> > >
> > > Cc: James E.J. Bottomley <JBottomley@xxxxxxxxxxxxx>
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > ---
> > >
> > > James, feel free to take this through your tree, or ACK it and I can
> > > take it through mine.
> > Just found this ... I have the stable folder rule be git-send-email and
> > from you, so it picks up your patches as well.
> It seems you aren't the only one who has procmail rules for my emails :)
It's not that I don't like you, I procmail it to a different folder
because of mobile phones: my inbox is about 50 deep and a stable patch
run can basically empty the cache ... this can be damn annoying if your
hotel reservation is number 51.
> I wonder if I need to start sending my stable stuff out from a different
> email address...
You don't need a different address, just use a different tag. I tag all
SCSI git email with
Ben Hutchings tags all his stable email with:
X-mailer: LinuxStableQueue (scripts by bwh)
and so on ... any header tag does ... I'm sure git-send-email can be
persuaded to add a more meaningful one.
> > I'll take it through my tree, just in case we're mucking about with
> > attributes this cycle around.
> That's fine with me, thanks.
OK, adding it to the testing queue now.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/