Re: [PATCHv2] bridge: disable snooping if there is no querier

From: David Miller
Date: Tue Jul 30 2013 - 19:10:46 EST


From: Linus Lüssing <linus.luessing@xxxxxx>
Date: Thu, 25 Jul 2013 15:56:20 +0200

> + atomic64_t multicast_querier_delay_time;

Please don't use an atomic64_t here, it's pointless.

You're only doing set and read operations on it, there's absolutely
nothing atomic about that.

You have to make sure that the top-level operations that use this
new value use an appropriate amount of locking on the higher level
objects.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/