Re: [PATCH] sky2: detect and prevent kernel panic from a possiblefaulty hardware
From: Stephen Hemminger
Date: Tue Jul 30 2013 - 19:32:50 EST
On Tue, 30 Jul 2013 16:19:06 -0700 (PDT)
David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Samuel Williams <sam8641@xxxxxxxxx>
> Date: Sat, 27 Jul 2013 15:35:54 -0500
> > A possible faulty hardware might interrupt with a status of 0xffffffff which
> > may kernel panic if sky2 driver tries to handle it. Detecting this problem
> > may avoid kernel panic.
> > Signed-off-by: Samuel Williams <sam8641@xxxxxxxxx>
> Sure, but then the device is basically just going to stop.
> I think this change needs to be more comprehensive, for example it
> needs to fully reset the device and try to get it operational again.
Not only that it is going to assert IRQ until the device is hard
reset. Plus it is not clear that cleaning up after sick hardware
is possible at all.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/