Re: [PATCH] mm, numa: Sanitize task_numa_fault() callsites

[Mel Gorman]

On Thu, Jul 25, 2013 at 12:38:45PM +0200, Peter Zijlstra wrote:
> 
> Subject: mm, numa: Sanitize task_numa_fault() callsites
> From: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Date: Mon Jul 22 10:42:38 CEST 2013
> 
> There are three callers of task_numa_fault():
> 
>  - do_huge_pmd_numa_page():
>      Accounts against the current node, not the node where the
>      page resides, unless we migrated, in which case it accounts
>      against the node we migrated to.
> 
>  - do_numa_page():
>      Accounts against the current node, not the node where the
>      page resides, unless we migrated, in which case it accounts
>      against the node we migrated to.
> 
>  - do_pmd_numa_page():
>      Accounts not at all when the page isn't migrated, otherwise
>      accounts against the node we migrated towards.
> 
> This seems wrong to me; all three sites should have the same
> sementaics, furthermore we should accounts against where the page
> really is, we already know where the task is.
> 

Agreed. To allow the scheduler parts to still be evaluated in proper
isolation I moved this patch to much earlier in the series.

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/