Re: [PATCH v2] PCI: Reset PCIe devices to stop ongoing DMA
From: Vivek Goyal
Date: Wed Jul 31 2013 - 12:10:27 EST
On Thu, Jul 25, 2013 at 11:00:46AM -0600, Bjorn Helgaas wrote:
> On Wed, Jul 24, 2013 at 12:29 AM, Takao Indoh
> <indou.takao@xxxxxxxxxxxxxx> wrote:
> > Sorry for letting this discussion slide, I was busy on other works:-(
> > Anyway, the summary of previous discussion is:
> > - My patch adds new initcall(fs_initcall) to reset all PCIe endpoints on
> > boot. This expects PCI enumeration is done before IOMMU
> > initialization as follows.
> > (1) PCI enumeration
> > (2) fs_initcall ---> device reset
> > (3) IOMMU initialization
> > - This works on x86, but does not work on other architecture because
> > IOMMU is initialized before PCI enumeration on some architectures. So,
> > device reset should be done where IOMMU is initialized instead of
> > initcall.
> > - Or, as another idea, we can reset devices in first kernel(panic kernel)
> > Resetting devices in panic kernel is against kdump policy and seems not to
> > be good idea. So I think adding reset code into iommu initialization is
> > better. I'll post patches for that.
> Of course nobody *wants* to do anything in the panic kernel. But
> simply saying "it's against kdump policy and seems not to be a good
> idea" is not a technical argument. There are things that are
> impractical to do in the kdump kernel, so they have to be done in the
> panic kernel even though we know the kernel is unreliable and the
> attempt may fail.
I think resetting all devices in crashed kernel is really a lot of
code. If there is a small piece of code, it can still be considered.
I don't know much about IOMMU or PCI or PCIE. But I am taking one step
back and discuss again the idea of not resetting the IOMMU in second
I think resetting the bus is a good idea but just resetting PCIE
will solve only part of the problem and we will same issues with
devices on other buses.
So what sounds more appealing if we could fix this particular
problem at IOMMU level first (and continue to develp patches for
resetting various buses).
In the past also these ideas have been proposed that continue to
use translation table from first kernel. Retain those mappings and
don't reset IOMMU. Reserve some space for kdump mappings in first
kernel and use that reserved mapping space in second kernel. It
never got implemented though.
Bjorn, so what's the fundamental problem with this idea?
Also, what's wrong with DMAR error. If some device tried to do DMA,
and DMA was blocked because IOMMU got reset and mappings are no more
there, why does it lead to failure. Shouldn't we just reate limit
error messages in such case and if device is needed, anyway driver
will reset it.
Other problem mentioned in this thread is PCI SERR. What is it? Is
it some kind of error device reports if it can't do DMA successfully.
Can these errors be simply ignored kdump kernel? This problem sounds
similar to a device keeping interrupt asserted in second kernel and
kernel simply disables the interrupt line if nobody claims the
IOW, it feels to me that we should handle the issue (DMAR error) at
IOMMU level first (instead of trying to make sure that by the time
we get to initialize IOMMU(), all devices in system have been quiesced
and nobody is doing DMA).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/