Re: [26/84] ARM: OMAP: RX-51: change probe order of touchscreen andpanel SPI devices

[Ben Hutchings]

On Thu, 2013-08-01 at 08:49 +0300, Tomi Valkeinen wrote:
> Hi,
> 
> On 31/07/13 16:23, Ben Hutchings wrote:
> > 3.2.50-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Aaro Koskinen <aaro.koskinen@xxxxxx>
> > 
> > commit e65f131a14726e5f1b880a528271a52428e5b3a5 upstream.
> > 
> > Commit 9fdca9df (spi: omap2-mcspi: convert to module_platform_driver)
> > broke the SPI display/panel driver probe on RX-51/N900. The exact cause is
> > not fully understood, but it seems to be related to the probe order. SPI
> > communication to the panel driver (spi1.2) fails unless the touchscreen
> > (spi1.0) has been probed/initialized before. When the omap2-mcspi driver
> > was converted to a platform driver, it resulted in that the devices are
> > probed immediately after the board registers them in the order they are
> > listed in the board file.
> 
> I'm not really familiar with this issue, but:
> 
> The commit 9fdca9df was merged to v3.5. Has that also been backported to
> 3.2? If not, I don't think this patch is needed for 3.2, as the patch
> causing the problem is not in 3.2.

It has not, but Sebastian reported that 3.2 was broken in the same way
so perhaps the blame was wrongly assigned in this commit message.
Sebastian, can you confirm that it is fixed with 3.2.50-rc1?

Ben.

-- 
Ben Hutchings
Who are all these weirdos? - David Bowie, about L-Space IRC channel #afp

Attachment: signature.asc
Description: This is a digitally signed message part