Re: [PATCH v6 2/8] ASoC: atmel: machine driver for at91sam9x5-wm8731boards

From: Mark Brown
Date: Thu Aug 01 2013 - 05:54:10 EST


On Wed, Jul 31, 2013 at 04:16:28PM -0600, Stephen Warren wrote:
> On 07/30/2013 04:58 PM, Mark Brown wrote:

> > You seem to be assuming that the strings are a bad thing. I'm not
> > sure that this is the case modulo the tooling issues...

> I do tend to think that using strings is pretty evil...

Well, they do avoid the legibility issues that tend to plague device
tree - I don't really mind if they're in the property names (as with
regulator supply properties) or in the data but having something that is
directly legible is a substantial win. Constants deal with this in the
source but they make runtime debugging more painful which isn't ideal.

Attachment: signature.asc
Description: Digital signature