Re: [Patch net-next v2 8/8] selinux: use generic union inet_addr

From: David Miller
Date: Fri Aug 02 2013 - 17:51:52 EST


From: Paul Moore <pmoore@xxxxxxxxxx>
Date: Fri, 02 Aug 2013 10:34:07 -0400

> On Friday, August 02, 2013 03:14:34 PM Cong Wang wrote:
>> From: Cong Wang <amwang@xxxxxxxxxx>
>>
>> selinux has some similar definition like union inet_addr,
>> it can re-use the generic union inet_addr too.
>>
>> Cc: James Morris <james.l.morris@xxxxxxxxxx>
>> Cc: Stephen Smalley <sds@xxxxxxxxxxxxx>
>> Cc: Eric Paris <eparis@xxxxxxxxxxxxxx>
>> Cc: Paul Moore <pmoore@xxxxxxxxxx>
>> Cc: linux-kernel@xxxxxxxxxxxxxxx
>> Cc: linux-security-module@xxxxxxxxxxxxxxx
>> Signed-off-by: Cong Wang <amwang@xxxxxxxxxx>
>
> Perhaps I'm confusing this with another patch but I though DaveM said he
> wasn't going to merge these patches?

I didn't like how he added completely unused bloat to various
datastructures because he unconditionally put a port field into
there.

He removed that problem this time, but there are still a lot of
things I don't like about this patch series.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/