Re: [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable

[Andi Kleen]

Namhyung Kim <namhyung@xxxxxxxxxx> writes:
>
> I wrote a patch series [1] separating gtk code to a dso and use it with
> libdl last year.  But I didn't get much feedback probably due to the
> mistake of not installing the dso to a proper place.  It'd be great if
> you guys take a look at it and give some comments.

It looks good as a replacement of this patch

Except for the requirement to build libperf as -fPIC
In some setups the PIC penalty can be high, and libperf
has some very hot code (e.g. callstack merging)

-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/