RE: [PATCH V1] DA9210 driver files

[Steve Twiss]

On Mon 15 July 2013 17:58 Mark Brown wrote:

>Subject: Re: [PATCH V1] DA9210 driver files

I should have named this PATCH V3 to follow on from previous versions
from RFC that I submitted. 

>To repeat *again* you should submit patches in the format covered in
>SubmittingPatches.  This includes things like the commit message, if
>your commit message doesn't look like other commit messages for the code
>you're changing that's an issue.

Apologies again.
I will try to make this identical to those provided in other commit 
messages ...

>
>> +struct da9210 {
>> +	struct device *dev;
>
>This is never used as far as I can tell.
>

Not used.. removed.

>> +MODULE_ALIAS("platform: da9210");
>
>This is for a platform device but this is an I2C device so would never
>match.  Also for a platform device the string should have no space in
>it.
>

Done this.
I will re-submit this asap.

>Otherwise this looks OK, though it'd be better to fill in the register
>map information more (listing the valid registers for example).

Thank you,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/