Re: [PATCH 1/5] pdev: Fix platform device resource linking

From: Russell King - ARM Linux
Date: Wed Aug 07 2013 - 04:27:52 EST


On Wed, Aug 07, 2013 at 02:57:00PM +0900, Greg Kroah-Hartman wrote:
> On Tue, Aug 06, 2013 at 11:19:14AM +0100, Russell King - ARM Linux wrote:
> > On Tue, Aug 06, 2013 at 06:15:27PM +0800, Greg Kroah-Hartman wrote:
> > > On Tue, Aug 06, 2013 at 12:45:42PM +0300, Pantelis Antoniou wrote:
> > > > What would it take to move all this into driver core?
> > >
> > > What specifically would you move into there?
> >
> > A variable to hold the streaming dma_mask, so that its in struct device
> > rather than having to be separate. Yes, we can keep the pointer in there
> > too, because that appears to convey meaning in the kernel today - whether
> > the device can do DMA or not.
> >
> > A NULL dma_mask pointer already means it can't and dma_set_mask() always
> > fails. A non-NULL dma_mask pointer means the driver can use
> > dma_set_mask() to set an appropriate mask.
>
> Ok, that sounds fine to me, for some reason I thought I said yes to this
> a long time ago, did no one ever send me a patch for it?

Apparantly not. I'll see what I can do, and I'll add it to my dma-masks
series, probably below most of the existing patches that are already
there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/