Re: [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIOcontroller on bf54x and bf60x.

[Sonic Zhang]

Hi Linus,

On Thu, Aug 8, 2013 at 2:56 AM, Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
> On Thu, Aug 1, 2013 at 9:31 AM, Sonic Zhang <sonic.adi@xxxxxxxxx> wrote:
>> On Tue, Jul 30, 2013 at 12:47 AM, Linus Walleij
>> <linus.walleij@xxxxxxxxxx> wrote:
>>> On Fri, Jul 26, 2013 at 6:57 AM, Sonic Zhang <sonic.adi@xxxxxxxxx> wrote:
>>>
>>>> Could you please comment on this patch set? It is based on your former comments.
>>>
>>> I'll get to it. I'm pretty choked right now and actually trying to have
>>> some vacation at the same time.
>>>
>>> In the meantime, after glancing over and noting prolific use of the
>>> unlikely() macro, please read the following articles:
>>> http://lwn.net/Articles/70473/
>>> http://lwn.net/Articles/420019/
>>>
>>
>> These articles say the directives should be rarely used. Do you
>> suggest to remove them from the patch?
>
> I think so? Or can you make a case for them being in
> a critical path, like have you run a profiler (such as perf)
> on the code and come to the conclusion that it's really
> needed for performance? In that case, spell it out in the
> patch description.
>

I don't have a profiler data. These directives are from the legacy
blackfin gpio driver based on developer's estimation. Removing it in
next patch set is fine to me.

In addition, do you have time to review the whole patch now?


Thanks

Sonic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/