Re: [PATCH 00/35] cpufreq: Introduce cpufreq_table_validate_and_show()

[Rafael J. Wysocki]

On Thursday, August 08, 2013 07:18:02 PM Viresh Kumar wrote:
> This is actually part of a bigger patchset which will change declaration of
> cpufreq_driver->target() to include index instead of target_freq and relation
> and hence cpufreq drivers wouldn't require to cpufreq_frequency_table_target()
> anymore.
> 
> Almost every cpufreq driver is required to validate its frequency table with:
> cpufreq_frequency_table_cpuinfo() and then expose it to cpufreq core with:
> cpufreq_frequency_table_get_attr().
> 
> This patch creates another helper routine cpufreq_table_validate_and_show() that
> will do both these steps in a single call and will return 0 for success, error
> otherwise.
> 
> This also fixes potential bugs in cpufreq drivers where people have called
> cpufreq_frequency_table_get_attr() before calling
> cpufreq_frequency_table_cpuinfo(), as the later may fail.
> 
> Viresh Kumar (35):
>   cpufreq: Add new helper cpufreq_table_validate_and_show()
>   cpufreq: pxa: call cpufreq_frequency_table_get_attr()
>   cpufreq: s3cx4xx: call cpufreq_frequency_table_get_attr()
>   cpufreq: sparc: call cpufreq_frequency_table_get_attr()
>   cpufreq: acpi-cpufreq: use cpufreq_table_validate_and_show()
>   cpufreq: arm_big_little: use cpufreq_table_validate_and_show()
>   cpufreq: blackfin: use cpufreq_table_validate_and_show()
>   cpufreq: cpufreq-cpu0: use cpufreq_table_validate_and_show()
>   cpufreq: cris: use cpufreq_table_validate_and_show()
>   cpufreq: davinci: use cpufreq_table_validate_and_show()
>   cpufreq: dbx500: use cpufreq_table_validate_and_show()
>   cpufreq: e_powersaver: use cpufreq_table_validate_and_show()
>   cpufreq: elanfreq: use cpufreq_table_validate_and_show()
>   cpufreq: exynos: use cpufreq_table_validate_and_show()
>   cpufreq: ia64-acpi: use cpufreq_table_validate_and_show()
>   cpufreq: imx6q: use cpufreq_table_validate_and_show()
>   cpufreq: kirkwood: use cpufreq_table_validate_and_show()
>   cpufreq: longhaul: use cpufreq_table_validate_and_show()
>   cpufreq: loongson2: use cpufreq_table_validate_and_show()
>   cpufreq: maple: use cpufreq_table_validate_and_show()
>   cpufreq: omap: use cpufreq_table_validate_and_show()
>   cpufreq: p4-clockmod: use cpufreq_table_validate_and_show()
>   cpufreq: pasemi: use cpufreq_table_validate_and_show()
>   cpufreq: pmac: use cpufreq_table_validate_and_show()
>   cpufreq: powernow: use cpufreq_table_validate_and_show()
>   cpufreq: ppc: use cpufreq_table_validate_and_show()
>   cpufreq: pxa: use cpufreq_table_validate_and_show()
>   cpufreq: s3cx4xx: use cpufreq_table_validate_and_show()
>   cpufreq: s5pv210: use cpufreq_table_validate_and_show()
>   cpufreq: sc520: use cpufreq_table_validate_and_show()
>   cpufreq: sh: use cpufreq_table_validate_and_show()
>   cpufreq: sparc: use cpufreq_table_validate_and_show()
>   cpufreq: spear: use cpufreq_table_validate_and_show()
>   cpufreq: speedstep: use cpufreq_table_validate_and_show()
>   cpufreq: tegra: use cpufreq_table_validate_and_show()
> 
>  drivers/cpufreq/acpi-cpufreq.c         |  4 +---
>  drivers/cpufreq/arm_big_little.c       |  4 +---
>  drivers/cpufreq/blackfin-cpufreq.c     |  3 +--
>  drivers/cpufreq/cpufreq-cpu0.c         |  4 +---
>  drivers/cpufreq/cris-artpec3-cpufreq.c | 10 +---------
>  drivers/cpufreq/cris-etraxfs-cpufreq.c | 10 +---------
>  drivers/cpufreq/davinci-cpufreq.c      |  6 ++----
>  drivers/cpufreq/dbx500-cpufreq.c       |  6 ++----
>  drivers/cpufreq/e_powersaver.c         |  3 +--
>  drivers/cpufreq/elanfreq.c             |  8 +-------
>  drivers/cpufreq/exynos-cpufreq.c       |  4 +---
>  drivers/cpufreq/exynos5440-cpufreq.c   |  4 +---
>  drivers/cpufreq/freq_table.c           | 12 ++++++++++++
>  drivers/cpufreq/ia64-acpi-cpufreq.c    |  4 +---
>  drivers/cpufreq/imx6q-cpufreq.c        |  3 +--
>  drivers/cpufreq/kirkwood-cpufreq.c     | 10 +---------
>  drivers/cpufreq/longhaul.c             |  8 +-------
>  drivers/cpufreq/loongson2_cpufreq.c    |  5 +----
>  drivers/cpufreq/maple-cpufreq.c        |  4 +---
>  drivers/cpufreq/omap-cpufreq.c         |  4 +---
>  drivers/cpufreq/p4-clockmod.c          |  3 +--
>  drivers/cpufreq/pasemi-cpufreq.c       |  4 +---
>  drivers/cpufreq/pmac32-cpufreq.c       |  3 +--
>  drivers/cpufreq/pmac64-cpufreq.c       |  4 +---
>  drivers/cpufreq/powernow-k6.c          |  9 +--------
>  drivers/cpufreq/powernow-k7.c          |  4 +---
>  drivers/cpufreq/powernow-k8.c          |  4 +---
>  drivers/cpufreq/ppc-corenet-cpufreq.c  |  3 +--
>  drivers/cpufreq/ppc_cbe_cpufreq.c      |  4 +---
>  drivers/cpufreq/pxa2xx-cpufreq.c       |  8 +++++---
>  drivers/cpufreq/pxa3xx-cpufreq.c       |  2 +-
>  drivers/cpufreq/s3c2416-cpufreq.c      |  4 +---
>  drivers/cpufreq/s3c24xx-cpufreq.c      |  2 +-
>  drivers/cpufreq/s3c64xx-cpufreq.c      |  2 +-
>  drivers/cpufreq/s5pv210-cpufreq.c      |  4 +---
>  drivers/cpufreq/sc520_freq.c           |  9 +--------
>  drivers/cpufreq/sh-cpufreq.c           |  6 +++---
>  drivers/cpufreq/sparc-us2e-cpufreq.c   |  2 +-
>  drivers/cpufreq/sparc-us3-cpufreq.c    |  2 +-
>  drivers/cpufreq/spear-cpufreq.c        |  5 ++---
>  drivers/cpufreq/speedstep-centrino.c   | 10 +---------
>  drivers/cpufreq/speedstep-ich.c        |  9 +--------
>  drivers/cpufreq/speedstep-smi.c        |  8 +-------
>  drivers/cpufreq/tegra-cpufreq.c        |  4 +---
>  include/linux/cpufreq.h                |  2 ++
>  45 files changed, 66 insertions(+), 167 deletions(-)

I'm not going to take this for 3.12, sorry.  Please resend in the 3.12-rc1 /
3.12-rc2 time frame.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/