Re: DMA masks

[Russell King - ARM Linux]

On Fri, Aug 09, 2013 at 12:34:11PM +0200, Krzysztof HaÅasa wrote:
> Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> writes:
> 
> >> struct device {
> >>         ...
> >> 
> >>         u64             *dma_mask;      /* dma mask (if dma'able device) */
> >> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >
> > "If dma-able device" gives a clue.  It is now the case that the DMA API
> > refuses DMA (via dma_supported) if the DMA mask pointer is NULL.
> 
> But precisely the same effect can be obtained by setting the (actual)
> dma_mask to 0 (most preferably, using DMA API's dma_set_mask()).
> This is what coherent_dma_mask does.

No.  If dma_mask is NULL, then dma_set_mask() will return -EIO no matter
what.  If dma_mask is non-NULL, dma_set_mask() will succeed if the mask
is supported by the hardware.  For example, on x86:

int dma_set_mask(struct device *dev, u64 mask)
{
        if (!dev->dma_mask || !dma_supported(dev, mask))
                return -EIO;

        *dev->dma_mask = mask;

        return 0;
}
EXPORT_SYMBOL(dma_set_mask);

and this is the same pattern we implement on ARM.  So, a valid dma_mask
pointer pointing at a variable holding zero can have a supported mask
set.

> Things like this:
> 	pdev1->dev.dma_mask = &pdev1->dev.coherent_dma_mask;
> 	pdev1->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> (which are all over the place) make me wonder what happens when some
> code requires and tries to set different masks for normal and coherent
> DMA.

Have you looked at my massive dma-masks patch series earlier this week?
Obviously you haven't...

The separate coherent and streaming masks are only required for a very
small subset of devices (rather systems - non-ARM I add).  For the
general case, especially on ARM where the above pattern seems to be
very prevalent, this does not apply; the two masks are always the same.
Many people took the above shortcut, and while not strictly correct, it
is a work-around for the shortcoming in the core device code.

What my patch set does is pull all that out into a central place so that
rather than having to modify a continually growing number of drivers when
we've decided how we're going fix this, we can fix it in one place and
switch everyone over at the same time.  That may not be needed now that
Greg has agreed to having stream_dma_mask in the struct device, but
even so I think removing the direct initialization from drivers is a good
idea.

> > However, placing the storage for the dma_mask pointer into struct device
> > is something which I've recently discussed with Greg, and is something
> > he'd like to see happen, so I'll be adding that to my DMA masks patch
> > series in the very near future.
> 
> Does this mean the dma_mask would remain a pointer, but it would point
> (usually) to a variable in struct device?

Yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/