Re: btrfs zero divide

From: Zach Brown
Date: Fri Aug 09 2013 - 14:05:34 EST


On Fri, Aug 09, 2013 at 02:26:36PM +0200, Andreas Schwab wrote:
> Josef Bacik <jbacik@xxxxxxxxxxxx> writes:
>
> > So stripe_len shouldn't be 0, if it is you have bigger problems :).
>
> The bigger problem is that stripe_nr is u64, this is completely bogus.
> The first operand of do_div must be u32. This goes through the whole
> file.

Definitely. Can we get some typeof() tricks in the macros to have the
build fail if (when, evidently) someone gets it wrong?

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/