Re: [PATCH] staging: Platform device tester - Allow removal

From: Greg Kroah-Hartman
Date: Tue Aug 13 2013 - 14:20:20 EST


On Tue, Aug 13, 2013 at 12:34:30PM +0300, Pantelis Antoniou wrote:
> This is a very simple device that allows testing of the removal path
> for platform devices.
>
> The only interface is a single writeable sysfs attribute (action).

Why not use the existing "unbind/bind" sysfs files that all busses
support? That's what userspace is expecting to use for adding and
removing devices from drivers from userspace.

This is a per-driver flag that the function platform_driver_probe() sets
for all platform drivers in the first line of that function. Remove
that line and see what happens :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/